spark-store-project/spark-store
13
0
Fork 0
mirror of https://gitee.com/spark-store-project/spark-store synced 2025-01-12 05:08:27 +08:00
Code Issues 2 Packages Projects Releases Wiki Activity

fix: crash when installation complete if MainWindow is closed

Browse Source 
Installation finished signal is triggered in child thread, which may cause crash when handling in AppInfoPage slot

Log: use Qt::ConnectionType::QueuedConnection when connecting with installation finished signal
This commit is contained in:
zty199 2024-11-12 17:34:28 +08:00
parent 5bd6ad9399
commit 29ddef300f
1 changed files with 12 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/pages/appintopage.cpp
View File

@ -287,8 +287,10 @@ void AppIntoPage::setDownloadWidget(DownloadListWidget *w)
}
dw = w;
connect(w, &DownloadListWidget::downloadFinished, [=]()
{ isDownloading(SparkAPI::getServerUrl() + SparkAPI::getArchDir() + spk.path() + "/" + info["Filename"].toString()); });
connect(w, &DownloadListWidget::downloadFinished, this, [=]() {
isDownloading(SparkAPI::getServerUrl() + SparkAPI::getArchDir() + spk.path() + "/" + info["Filename"].toString());
},
Qt::QueuedConnection);
}
void AppIntoPage::initUI()
@ -486,7 +488,10 @@ void AppIntoPage::on_downloadButton_clicked()
return;
}
connect(item, &DownloadItem::finished, [=]() { isDownloading(downloadUrl); });
connect(item, &DownloadItem::finished, this, [=]() {
isDownloading(downloadUrl);
},
Qt::QueuedConnection);
item->install(0);
isDownloading(downloadUrl);
@ -507,7 +512,10 @@ void AppIntoPage::on_downloadButton_clicked()
item->reinstall = true;
}
ui->downloadButton->setEnabled(false);
connect(item, &DownloadItem::finished, [=]() { isDownloading(downloadUrl); });
connect(item, &DownloadItem::finished, this, [=]() {
isDownloading(downloadUrl);
},
Qt::QueuedConnection);
isDownloading(downloadUrl);
}