spark-store-project/spark-store
15
0
Fork 0
mirror of https://gitee.com/spark-store-project/spark-store synced 2025-12-18 10:01:38 +08:00
Code Issues 1 Packages Projects Releases Wiki Activity

fix: rarely crash after install finished

Browse Source 
in DownloadItem::slotAsyncInstall, QProcess should not be deleteLater
since it is not pointer

Log: fix rarely crash; move installExtraArg set before download started
This commit is contained in:
忘记、过去
2025-06-07 13:39:55 +08:00
parent 1c43f11645
commit bc7e6bdb95
4 changed files with 28 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

37
src/pages/appintopage.cpp
View File

@@ -535,7 +535,27 @@ void AppIntoPage::on_downloadButton_clicked()
emit clickedDownloadBtn();
DownloadItem *item = dw->addItem(info["Name"].toString(), info["Filename"].toString(), info["Pkgname"].toString(), iconpixmap, downloadUrl);
// 处理 tags，设置 installExtraArg
QString installExtraArg;
#if QT_VERSION >= QT_VERSION_CHECK(5, 15, 0)
QStringList taglist = info["Tags"].toString().split(";", Qt::SkipEmptyParts);
#else
QStringList taglist = info["Tags"].toString().split(";", QString::SkipEmptyParts);
#endif
if (taglist.contains("native")) {
installExtraArg = "--native";
} else if (taglist.contains("amber-ce-bookworm")) {
installExtraArg = "--amber-ce-bookworm";
} else if (taglist.contains("amber-ce-trixie")) {
installExtraArg = "--amber-ce-trixie";
} else if (taglist.contains("amber-ce-sid")) {
installExtraArg = "--amber-ce-sid";
} else if (taglist.contains("amber-ce-deepin23")) {
installExtraArg = "--amber-ce-deepin23";
}
DownloadItem *item = dw->addItem(info["Name"].toString(), info["Filename"].toString(), info["Pkgname"].toString(),
iconpixmap, downloadUrl, installExtraArg);
if (item == nullptr)
{
return;
@@ -551,21 +571,6 @@ void AppIntoPage::on_downloadButton_clicked()
Qt::QueuedConnection);
isDownloading(downloadUrl);
// 处理 tags，设置 installExtraArg
QString tags = info["Tags"].toString();
QStringList taglist = tags.split(";", Qt::SkipEmptyParts);
if (taglist.contains("native")) {
item->installExtraArg = "--native";
} else if (taglist.contains("amber-ce-bookworm")) {
item->installExtraArg = "--amber-ce-bookworm";
} else if (taglist.contains("amber-ce-trixie")) {
item->installExtraArg = "--amber-ce-trixie";
} else if (taglist.contains("amber-ce-sid")) {
item->installExtraArg = "--amber-ce-sid";
} else if (taglist.contains("amber-ce-deepin23")) {
item->installExtraArg = "--amber-ce-deepin23";
}
}
void AppIntoPage::on_pushButton_3_clicked()