spark-store-project/spark-store
15
0
Fork 0
mirror of https://gitee.com/spark-store-project/spark-store synced 2025-12-16 17:11:37 +08:00
Code Issues 1 Packages Projects Releases Wiki Activity

fix: rarely crash after install finished

Browse Source 
in DownloadItem::slotAsyncInstall, QProcess should not be deleteLater
since it is not pointer

Log: fix rarely crash; move installExtraArg set before download started
This commit is contained in:
忘记、过去
2025-06-07 13:39:55 +08:00
parent 1c43f11645
commit bc7e6bdb95
4 changed files with 28 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/widgets/common/downloaditem.cpp
View File

@@ -252,8 +252,5 @@ void DownloadItem::slotAsyncInstall(int t)
ui->widget_spinner->hide();
DownloadItem::isInstall = false;
installer.deleteLater();
isInstall.deleteLater();
emit finished(error == 0 && !haveError && !notRoot);
}

5
src/widgets/downloadlistwidget.cpp
View File

@@ -85,7 +85,9 @@ void DownloadListWidget::clearItem()
ui->listWidget->clear();
}
DownloadItem* DownloadListWidget::addItem(QString name, QString fileName, QString pkgName, const QPixmap icon, QString downloadurl)
DownloadItem* DownloadListWidget::addItem(QString name, QString fileName, QString pkgName,
const QPixmap icon, QString downloadurl,
const QString &installExtraArg)
{
if (fileName.isEmpty())
{
@@ -104,6 +106,7 @@ DownloadItem* DownloadListWidget::addItem(QString name, QString fileName, QStrin
di->setName(name);
di->setFileName(fileName);
di->pkgName = pkgName;
di->installExtraArg = installExtraArg;
di->seticon(icon);
QListWidgetItem *pItem = new QListWidgetItem();
pItem->setSizeHint(QSize(240, 56)); // ui 中单个 downloaditem 高度固定 56px（上下 margin 8px，图片固定 48x48）

4
src/widgets/downloadlistwidget.h
View File

@@ -19,7 +19,9 @@ class DownloadListWidget : public DBlurEffectWidget
Q_OBJECT
public:
DownloadItem *addItem(QString name, QString fileName, QString pkgName, const QPixmap icon, QString downloadurl);
DownloadItem *addItem(QString name, QString fileName, QString pkgName,
const QPixmap icon, QString downloadurl,
const QString &installExtraArg);
int nowDownload = 0;
int allDownload = 0;
int toDownload = 0;