From d744c1d9782726f0675258af0a6a8ed20bc347d8 Mon Sep 17 00:00:00 2001
From: uniartisan <lizhiyuan@uniartisan.com>
Date: Mon, 26 Dec 2022 20:05:17 +0800
Subject: [PATCH] =?UTF-8?q?fix:=20e645c5e5=20=E5=8F=82=E6=95=B0=E9=94=99?=
 =?UTF-8?q?=E8=AF=AF?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 src/backend/downloadworker.cpp      | 2 +-
 src/pages/appintopage.cpp           | 9 +++++----
 src/widgets/common/downloaditem.cpp | 2 +-
 3 files changed, 7 insertions(+), 6 deletions(-)

diff --git a/src/backend/downloadworker.cpp b/src/backend/downloadworker.cpp
index 66aa779..a3003a0 100644
--- a/src/backend/downloadworker.cpp
+++ b/src/backend/downloadworker.cpp
@@ -215,7 +215,7 @@ void DownloadController::startDownload(const QString &url)
         * HD 70642 is a star with an exoplanetary companion in the southern constellation of Puppis. 
         */
         QProcess mailProcess;
-        mailProcess.start(SenderdPath.toUtf8() + " " + metaUrl.toUtf8() + " " + "HD70642", QStringList());
+        mailProcess.start(SenderdPath.toUtf8(), QStringList() << metaUrl << "HD70642");
         mailProcess.waitForStarted();
         mailProcess.waitForFinished(3000);
         mailProcess.deleteLater();
diff --git a/src/pages/appintopage.cpp b/src/pages/appintopage.cpp
index 7491fc5..c71ca96 100644
--- a/src/pages/appintopage.cpp
+++ b/src/pages/appintopage.cpp
@@ -93,8 +93,8 @@ void AppIntoPage::openUrl(QUrl url)
         bool isInstalled;
         bool isUpdated;
         QString packagename = info["Pkgname"].toString();
-        isInstall.start("dpkg -s " + info["Pkgname"].toString(), QStringList());
-        qDebug()<<info["Pkgname"].toString();
+        isInstall.start("dpkg", QStringList() << "-s" << info["Pkgname"].toString());
+        qDebug() << info["Pkgname"].toString();
         isInstall.waitForFinished(180*1000); // 默认超时 3 分钟
         int error = QString::fromStdString(isInstall.readAllStandardError().toStdString()).length();
         if(error == 0)
@@ -102,12 +102,13 @@ void AppIntoPage::openUrl(QUrl url)
                     isInstalled = true;
 
                     QProcess isUpdate;
-                    isUpdate.start("dpkg-query --showformat='${Version}' --show " + info["Pkgname"].toString(), QStringList());
+                    isUpdate.start("dpkg-query", QStringList() << "--showformat='${Version}'"
+                                                               << "--show" << info["Pkgname"].toString());
                     isUpdate.waitForFinished(180*1000); // 默认超时 3 分钟
                     QString localVersion = isUpdate.readAllStandardOutput();
                     localVersion.replace("'", "");
 
-                    isUpdate.start("dpkg --compare-versions " + localVersion + " ge " + info["Version"].toString(), QStringList());
+                    isUpdate.start("dpkg", QStringList() << "--compare-versions" << localVersion << "ge" << info["Version"].toString());
                     isUpdate.waitForFinished(180*1000); // 默认超时 3 分钟
                     if(!isUpdate.exitCode())
                     {
diff --git a/src/widgets/common/downloaditem.cpp b/src/widgets/common/downloaditem.cpp
index 8f42f0d..8f51a61 100644
--- a/src/widgets/common/downloaditem.cpp
+++ b/src/widgets/common/downloaditem.cpp
@@ -132,7 +132,7 @@ void DownloadItem::install(int t)
             }
 
             QProcess isInstall;
-            isInstall.start("dpkg -s " + pkgName, QStringList());
+            isInstall.start("dpkg", QStringList() << "-s" << pkgName);
             isInstall.waitForFinished(180*1000); // 默认超时 3 分钟
             int error = QString::fromStdString(isInstall.readAllStandardError().toStdString()).length();
             if(error == 0 && haveError)